Dont check for NaTType, just NaT #17564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Sep 17, 2017
| @@ -572,7 +572,7 @@ def test_implementation_limits(self): | |||
| assert max_td.value == np.iinfo(np.int64).max | |||
|
|
|||
| # Beyond lower limit, a NAT before the Overflow | |||
| assert isinstance(min_td - Timedelta(1, 'ns'), NaTType) | |||
| assert min_td - Timedelta(1, 'ns') is NaT | |||
jreback
added
Missing-data
jreback
reviewed
Sep 17, 2017
| @@ -470,7 +469,7 @@ def encode(obj): | |||
| } | |||
|
|
|||
| elif isinstance(obj, (datetime, date, np.datetime64, timedelta, | |||
| np.timedelta64, NaTType)): | |||
There was a problem hiding this comment.
FYI:
In [40]: np.timedelta64('nat') is pd.NaT
Out[40]: False
In [41]: pd.Timedelta(np.timedelta64('nat')) is pd.NaT
Out[41]: True
this is reason for the complex type checking around NaTs; numpy has a 'nat' like value embedded in np.timedelta64/np.datetime64 (however its not very useful).
jreback
approved these changes
Sep 17, 2017
|
lgtm. merge on green. |
|
Test error is in |
|
no just rebase |
Codecov Report
@@ Coverage Diff @@
## master #17564 +/- ##
==========================================
- Coverage 91.19% 91.17% -0.02%
==========================================
Files 163 163
Lines 49626 49625 -1
==========================================
- Hits 45258 45248 -10
- Misses 4368 4377 +9
Continue to review full report at Codecov.
|
4 tasks
|
thanks! |
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff